CLI now consistently forward URLs to native/web viewer when possible #10909

Wumpf · 2025-08-14T14:26:47Z

What

This bottoms out in a long overdue refactor of our CLI entry point!
The key idea underpinning the CLI entry point refactor is that URLs should be processed differently depending on what we want to do with them: Whenever possible, we should not create a data source directly and instead forward them to the (web) viewer.
Still not amazing in structure, but imho way easier to follow now and probably fixes some subtle bugs as well.

Mostly manual testing, since this area unfortunately doesn't have a lot of unit testing:

github-actions · 2025-08-14T14:28:07Z

Web viewer built successfully. If applicable, you should also test it:

I have tested the web viewer

Result	Commit	Link	Manifest
✅	`e5d7a6b`	https://rerun.io/viewer/pr/10909	`+nightly` `+main`

^{Note: This comment is updated whenever you push a commit.}

Wumpf · 2025-08-14T14:28:22Z

crates/store/re_data_source/src/data_source.rs

+/// Somewhere we can get Rerun logging data from.
 #[derive(Clone, Debug)]
-pub enum DataSource {
+pub enum LogDataSource {


it's always been a log data source, it's just that the clarification until somewhat recently wasn't really necessary

crates/store/re_data_source/src/data_source.rs

Wumpf · 2025-08-14T15:39:00Z

not sure what's up with cargo-shear. The dependency it complains about is not there anymore 🤨

github-actions · 2025-08-14T16:09:40Z

Latest documentation preview deployed successfully.

Result	Commit	Link
✅	`e5d7a6b`	https://landing-785p0bs19-rerun.vercel.app/docs

^{Note: This comment is updated whenever you push a commit.}

Wumpf · 2025-08-14T17:57:22Z

@rerun-bot full-check

github-actions · 2025-08-14T17:57:52Z

Started a full build: https://github.com/rerun-io/rerun/actions/runs/16972831822

…e-link-handling

abey79

Well great stuff ❤️ I definitely feels that the complexity of our model is increasingly becoming the bottleneck for further improving this code (maybe at the exception of these "mode of operation" I noted below, where dumb code shuffling might actual help).

crates/store/re_data_source/src/data_source.rs

crates/top/rerun/src/commands/entrypoint.rs

abey79 · 2025-08-15T09:25:39Z

crates/top/rerun/src/commands/entrypoint.rs

+struct UrlParamProcessingConfig {
+    data_sources_from_http_urls: bool,
+    data_sources_from_redap_datasets: bool,
+    data_source_from_filepaths: bool,
+}


I suppose this embodies "what doesn't right" by you 😅 Can't say I'm in love either, but at least this is very explicit at what its doing.

abey79 · 2025-08-15T09:28:24Z

crates/top/rerun/src/commands/entrypoint.rs

+    #[allow(dead_code)] // May be unused depending on feature flags.
+    fn grpc_server_and_web_viewer() -> Self {
+        // GRPC with web viewer can handle everything except files directly.
+        Self {
+            data_sources_from_http_urls: false,
+            data_sources_from_redap_datasets: false,
+            data_source_from_filepaths: true,
+        }
+    }


This guy right here is the weird one. If we didn't support loading local file path from web viewer, we would be in a simpler world where we either eagerly (proxy) or lazily (native) convert everything to data sources, which could simplify stuff a bit more.

Do we really have reasons to support this use case?

(caveat: i may not understand correctly any of this and be completely wrong)

rerun --web-viewer some-local-file.rrd is nice to support I think. Doesn't hurt too much I'd say

abey79 · 2025-08-15T09:32:21Z

crates/viewer/re_viewer/src/app.rs

+    /// Makes the first recording store active that is found for a given data source if any.
+    fn try_make_recording_from_source_active(
+        &self,
+        egui_ctx: &egui::Context,
+        store_hub: &mut StoreHub,
+        new_source: &SmartChannelSource,
+    ) {
+        if let Some(entity_db) = store_hub.find_recording_store_by_source(new_source) {
+            let store_id = entity_db.store_id().clone();
+            debug_assert!(store_id.is_recording()); // `find_recording_store_by_source` should have filtered for recordings rather than blueprints.
+            self.make_store_active_and_highlight(store_hub, egui_ctx, &store_id);
+        }
+    }


Some version of that facility might be nice to have for the new recording panel impl 🤔

happy to move around. was just a utility I've split after seeing the code for the third time

jprochazk

The diff isn't negative, argh!

Thanks for taking a stab at this. This is definitely an improvement. I ran some basic commands, but I believe we should merge it and crowd-source testing from the team 🙂.

Long-term, I wish we were more explicit, splitting different operating modes into their own commands. Or even better, reducing the number of operating modes...

abey79 · 2025-08-15T12:45:30Z

Long-term, I wish we were more explicit, splitting different operating modes into their own commands. Or even better, reducing the number of operating modes...

💯

Wumpf · 2025-08-15T14:19:47Z

The diff isn't negative, argh!

Felt the same. It really was supposed to be on this one 😅

Wumpf · 2025-08-15T14:22:14Z

@rerun-bot full-check

github-actions · 2025-08-15T14:22:43Z

Started a full build: https://github.com/rerun-io/rerun/actions/runs/16992022908

Wumpf · 2025-08-15T16:16:41Z

@rerun-bot full-check

github-actions · 2025-08-15T16:17:12Z

Started a full build: https://github.com/rerun-io/rerun/actions/runs/16994236785

Wumpf · 2025-08-15T16:32:40Z

@rerun-bot full-check

github-actions · 2025-08-15T16:33:12Z

Started a full build: https://github.com/rerun-io/rerun/actions/runs/16994529561

### Related * Follow-up to #10909 * related to https://linear.app/rerun/project/unblock-more-frequent-releases-fd370b484c42 ### What This broke pretty much all standard SDK->Viewer connections 😱

Wumpf added 9 commits August 14, 2025 11:25

remove unused methods from datasource

f5af08d

remove unnecessary DataSourceCommand indirection

0e81654

Forward Redap URIs directly to the viewer

8465ea6

remove filename test on datasource (unused filename method)

15f7f2b

restructure entry point to handle URLs depending on where the data goes

26d92db

Fix clippy & compile errors

70fecc0

implement checking for already open redap proxy source

c58144b

handle catalog & entry uris in url opening method

2c7b382

rename DataSource to LogDataSource, clean up some unused methods

a0497f3

Wumpf added 📺 re_viewer affects re_viewer itself include in changelog labels Aug 14, 2025

typo & cleanup

acd585c

Wumpf commented Aug 14, 2025

View reviewed changes

crates/store/re_data_source/src/data_source.rs Outdated Show resolved Hide resolved

Wumpf added 6 commits August 14, 2025 16:30

unexpected cargo shear fix

6a09a70

doc & compilation fixes

769aec8

fix save not listening, fix --connect not connecting

d1c96c4

minor cleanup

c609932

fix data source uri parsing tests

e637d2b

update cargo shear on ci to get rid of strange false positive?

589d41c

Wumpf added 3 commits August 14, 2025 17:47

fix datasets urls not being forwarded

188105b

Update cli.md

a9009a2

url processing config fixes

4109a11

Wumpf requested a review from abey79 August 14, 2025 16:13

Wumpf assigned jprochazk and unassigned jprochazk Aug 14, 2025

Wumpf requested a review from jprochazk August 14, 2025 16:14

Wumpf marked this pull request as ready for review August 14, 2025 16:14

fix test-receive not running a server

561ce19

Wumpf added 3 commits August 14, 2025 19:58

cargo shear fix

9532439

Merge remote-tracking branch 'origin/main' into andreas/fix-datasourc…

6f1d04b

…e-link-handling

advanced clippy happiness

a03b0ab

abey79 approved these changes Aug 15, 2025

View reviewed changes

jprochazk approved these changes Aug 15, 2025

View reviewed changes

Wumpf added 2 commits August 15, 2025 15:39

renames

066cc46

add migration guide

b7d1571

pull out functions for all the various entry point operating modes

09d4767

Wumpf added 2 commits August 15, 2025 16:39

entry point compilation variation fixes

26a7461

rerun-lint

c34c4e8

rerun-io deleted a comment from github-actions bot Aug 15, 2025

update migration guide link. Good ci!

d868957

fix unused variables on some build configs

e5d7a6b

Wumpf mentioned this pull request Aug 15, 2025

Open any importable link from command palette #10927

Merged

Wumpf merged commit bafcced into main Aug 16, 2025
80 of 83 checks passed

Wumpf deleted the andreas/fix-datasource-link-handling branch August 16, 2025 07:26

Wumpf mentioned this pull request Aug 23, 2025

Fix SDK->Viewer connection #10977

Merged

CLI now consistently forward URLs to native/web viewer when possible #10909

CLI now consistently forward URLs to native/web viewer when possible #10909

Uh oh!

Conversation

Wumpf commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related

What

Uh oh!

github-actions bot commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Wumpf Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Wumpf commented Aug 14, 2025

Uh oh!

github-actions bot commented Aug 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Wumpf commented Aug 14, 2025

Uh oh!

github-actions bot commented Aug 14, 2025

Uh oh!

abey79 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

abey79 Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

abey79 Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

Wumpf Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

abey79 Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

Wumpf Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

jprochazk left a comment

Choose a reason for hiding this comment

Uh oh!

abey79 commented Aug 15, 2025

Uh oh!

Wumpf commented Aug 15, 2025

Uh oh!

Wumpf commented Aug 15, 2025

Uh oh!

github-actions bot commented Aug 15, 2025

Uh oh!

Wumpf commented Aug 15, 2025

Uh oh!

github-actions bot commented Aug 15, 2025

Uh oh!

Wumpf commented Aug 15, 2025

Uh oh!

github-actions bot commented Aug 15, 2025

Uh oh!

Uh oh!

Uh oh!

Wumpf commented Aug 14, 2025 •

edited

Loading

github-actions bot commented Aug 14, 2025 •

edited

Loading

github-actions bot commented Aug 14, 2025 •

edited

Loading