Open any importable link from command palette #10927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
cd94aac to
a79318b
Compare
a79318b to
83b1b56
Compare
abey79
approved these changes
Aug 22, 2025
Comment on lines
137
to
138
| // All of these send commands, make sure they'll be processed. | ||
| egui_ctx.request_repaint(); |
There was a problem hiding this comment.
The fact that the system command queue is not empty at the end of a frame should automatically trigger a request repaint, so we don't have to think of it here.
83b1b56 to
481a70b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Command palette (cmd/ctrl + P) can now import links!
(didn't untangle those two into separate PRs because I ran out of time, sorry!)
Command palette is sensitive to what kind of link you provide:
command.palette.knows.too.much.mov