Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

oxkitsune
Copy link
Member

What

Update MCAP loader to prefer the opened store when available, falling back to the recommended store ID if none is opened.

This was causing the recording to split in two when loading an MCAP file using the SDK.

@oxkitsune oxkitsune added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself exclude from changelog PRs with this won't show up in CHANGELOG.md labels Aug 28, 2025
Copy link

github-actions bot commented Aug 28, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
395a96e https://rerun.io/viewer/pr/11031 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that correct though? Sounds like with that everything becomes an import and we never open a new recording. Or does something already switch to a new recording for mcap? In that case plz document that & why at the changed callsite

@oxkitsune
Copy link
Member Author

is that correct though? Sounds like with that everything becomes an import and we never open a new recording. Or does something already switch to a new recording for mcap? In that case plz document that & why at the changed callsite

This avoids everything being a new recording. When loading in a file programmatically (e.g. using load_file_from_path like in the snippet in #11027), we expect it to load the mcap file into the recording that we've created using rr.init.

This changes the behavior slightly;

  • when dragging an mcap file into the viewer, it will create a new recording for that file, unless there's a recording that's already open.
  • when loading an mcap file using the cli, it will create a new recording regardless of whether there's one open already.
  • when calling load_file_from_path it will respect the open recording instead of always creating a new recording.

@Wumpf
Copy link
Member

Wumpf commented Aug 29, 2025

thank, I think that makes sense

@Wumpf Wumpf merged commit 18c5423 into main Aug 29, 2025
40 checks passed
@Wumpf Wumpf deleted the gijs/fix-mcap-application-id branch August 29, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants