Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Aug 29, 2025

Related

What

You can already open URLs from CLI and command line. But this modal dialog makes it a bit more discoverable still since this way we can put a menu item in the menu.

It's designed to be completely controlable by shortcuts:

  • CTRL/CMD + SHIFT + L to open it
  • CTRL/CMD + V to paste (the URL field is selected)
    • experimented with auto pasting the contents on opening. Works but gets very awkward if the clipboard contents are something secret/private/else entirely
  • Enter to import
Screen.Recording.2025-09-02.at.13.09.49.mov

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself include in changelog labels Aug 29, 2025
@Wumpf Wumpf requested review from abey79 and gavrelina August 29, 2025 09:05
Copy link

github-actions bot commented Aug 29, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
4746aa4 https://rerun.io/viewer/pr/11040 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf changed the title New import from URL dialog New open from URL dialog & main menu entry Aug 29, 2025
@Wumpf Wumpf force-pushed the andreas/link-dialog branch 3 times, most recently from 570c167 to 7946ca5 Compare August 29, 2025 16:15
@Wumpf Wumpf marked this pull request as draft August 29, 2025 19:26
@Wumpf
Copy link
Member Author

Wumpf commented Aug 29, 2025

Drafted: got a more improved & detailed design and some feedback from @gavrelina

@Wumpf Wumpf force-pushed the andreas/link-dialog branch from 7946ca5 to ceae9a7 Compare September 2, 2025 11:10
@Wumpf Wumpf removed the request for review from gavrelina September 2, 2025 11:11
@Wumpf Wumpf marked this pull request as ready for review September 2, 2025 11:12
@Wumpf
Copy link
Member Author

Wumpf commented Sep 2, 2025

(ci failure is rustsec advisory that has been fixed on main by now)

Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Wumpf Wumpf force-pushed the andreas/link-dialog branch from 2daac0d to 17e8c61 Compare September 3, 2025 08:32
@Wumpf Wumpf force-pushed the andreas/link-dialog branch from a80fb5a to 4746aa4 Compare September 3, 2025 09:15
@Wumpf Wumpf merged commit 313cbb4 into main Sep 3, 2025
78 of 80 checks passed
@Wumpf Wumpf deleted the andreas/link-dialog branch September 3, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow opening links from command pallete & main menu
2 participants