Add MCAP parsers for scalar sensor messages #11078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
3ee781b to
6bf6944
Compare
6bf6944 to
ea1909e
Compare
aedm
reviewed
Sep 4, 2025
| /// | ||
| /// Returns a vector of (`field_name`, `value`) pairs where `field_name` is used | ||
| /// for labeling in the visualization and `value` is the scalar measurement. | ||
| fn extract_scalars(&self) -> Vec<(&str, f64)>; |
There was a problem hiding this comment.
A default implementation would be nice. :)
There was a problem hiding this comment.
I don't think it makes sense to have a default implementation for that function, as each struct should implement it
There was a problem hiding this comment.
I mean there are structs that could utilize a serde-based field enumeration. But it's probably overkill.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
This adds a generic
ScalarMessageParserwhich supports ROS2 messages that implement a newScalarExtractortrait. This generic parser is then used for the following ROS2 messages that contain simple scalar values:sensor_msgs/msg/Temperaturesensor_msgs/msg/FluidPressuresensor_msgs/msg/RelativeHumiditysensor_msgs/msg/Illuminancesensor_msgs/msg/Rangesensor_msgs/msg/BatteryState