Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

IsseW
Copy link
Member

@IsseW IsseW commented Sep 2, 2025

Related

Fixes #11049.

What

This adds cache-eviction similarly to how it's done in crates/viewer/re_viewer_context/src/cache/image_decode_cache.rs. Store a last_used_generation for each cache entry, and if it wasn't used within the last frame we evict it.

@IsseW IsseW added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself include in changelog labels Sep 2, 2025
Copy link

github-actions bot commented Sep 2, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
b6a1e85 https://rerun.io/viewer/pr/11079 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
very happy we went with that much simpler route now rather than overengineering the cache entry update as we discussed first. For now 😁

@IsseW IsseW merged commit ebbbc8a into main Sep 2, 2025
36 checks passed
@IsseW IsseW deleted the isse/fix-mesh-cache-eviction branch September 2, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing albedo factor on a mesh causes massive vram memory leaks
2 participants