Make archetype and URDF loaders honor entity_path_prefix
#11085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Wumpf
approved these changes
Sep 3, 2025
| ); | ||
|
|
||
| // Windows paths | ||
| #[cfg(target_os = "windows")] |
There was a problem hiding this comment.
shouldn't those paths also work when not building for windows?
There was a problem hiding this comment.
No they do not 🫠
For unix targets it freaks out at the \ instead of / and turns it into a path component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
entity_path_prefixinto account #8344What
Both
loader_archetypeandloader_urdfnow honorentity_path_prefixwhen it is set. The LeRobot and MCAP loaders do not, since their entity paths directly reflect the structure of the data being loaded.