Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prevent arow_cpp from configuring/building/installing all the time #11093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2025
Merged

Prevent arow_cpp from configuring/building/installing all the time #11093

merged 1 commit into from
Sep 15, 2025

Conversation

eliemichel
Copy link
Contributor

@eliemichel eliemichel commented Sep 3, 2025 •
edited
Loading

This addresses the following issue: whenever I build my cmake project based on Rerun C++ hello world, the arrow_cpp target gets re-configured, re-built and re-installed even though it did not change (and I did not even try to install my build):

>cmake --build build
MSBuild version 17.8.5+b5265ef37 for .NET Framework

  Checking File Globs
  1>Performing update step for 'arrow_cpp'
  -- Already at requested tag: apache-arrow-18.0.0
  No patch step for 'arrow_cpp'
  Performing configure step for 'arrow_cpp'
  -- arrow_cpp configure command succeeded.  See also C:/Users/emichel/SourceCode/SparkleOptimizer3/build/_deps/rerun_sdk-build/arrow/src/arrow_cpp-stamp/a
  rrow_cpp-configure-*.log
  Performing build step for 'arrow_cpp'
  -- arrow_cpp build command succeeded.  See also C:/Users/emichel/SourceCode/SparkleOptimizer3/build/_deps/rerun_sdk-build/arrow/src/arrow_cpp-stamp/arrow
  _cpp-build-*.log
  Performing install step for 'arrow_cpp'
  -- arrow_cpp install command succeeded.  See also C:/Users/emichel/SourceCode/SparkleOptimizer3/build/_deps/rerun_sdk-build/arrow/src/arrow_cpp-stamp/arr
  ow_cpp-install-*.log
  Completed 'arrow_cpp'
  rerun_sdk.vcxproj -> C:\Users\emichel\SourceCode\SparkleOptimizer3\build\_deps\rerun_sdk-build\Debug\rerun_sdk.lib

This is addressed by adding an empty UPDATE_COMMAND to the external project definition.

PS: Is there any reason why this is an ExternalProject and not a FetchContent?

@eliemichel
Update download_and_build_arrow.cmake
14ee792 
Prevent arow_cpp from configuring/building/installing all the time
@oxkitsune
Copy link
Member

Have you tried passing -DRERUN_DOWNLOAD_AND_BUILD_ARROW=OFF?

Related: Installing ArrowCpp separately.

@eliemichel
Copy link
Contributor Author

Mmh yes but I don't want to install it separately, I like the fact that it is installed with rerun because I don't want to have to impose any sort of dependency manager like pixie to my end users.

@Wumpf Wumpf self-requested a review September 3, 2025 12:22
Wumpf
Wumpf approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observed needless reconfigure as well, so having a solution for that sounds great! Tried it locally and works like a charm.

Do I understand correctly that this will essentially prevent CMake from continuously checking (& updating) the already pinned arrow version? Would be nice to add some more commentary there :)

PS: Is there any reason why this is an ExternalProject and not a FetchContent?

Don't recall unfortunately :/

@Wumpf Wumpf added sdk-cpp C/C++ API specific include in changelog labels Sep 3, 2025
@Wumpf Wumpf merged commit 6aa7f8d into rerun-io:main Sep 15, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog sdk-cpp C/C++ API specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliemichel @oxkitsune @Wumpf