Add options to gRPC proxy server to replay _newest_ data first #11118
Conversation
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
3e4ec64 to
1088bd9
Compare
| persistent.iter().rev(), | ||
| static_.iter().rev(), |
There was a problem hiding this comment.
I'd be curious what happens if you have a VideoFrameReference and static AssetVideo, and then the frame references come before the video 🤔. But persistent and static probably don't need to be reversed, right?
There was a problem hiding this comment.
Our viewer should be robust to out-of-order chunks, so likely you will have an on-screen video-error until the video chunk is received. More likely this feature will be used by people doing video streams though.
As for static: some people use static logging as a way to log "transient" data (e.g. many images), and in that case we again want to show the latest first, hence the .rev
There was a problem hiding this comment.
some people use static logging as a way to log "transient" data (e.g. many images), and in that case we again want to show the latest first, hence the .rev
if only we had an in-memory server which used an actual chunk store so we could discard static data when it is overwritten 😅
There was a problem hiding this comment.
While it will work fine'ish with VideoFrameRefernece, we actually completely break down with out of order chunks for VideoStream. Need to create a follow-up issue about this.
We have other places where we hit this limitation. E.g.:
it's not entirely trivial to fix this, but we have to look into it
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
9aa9a41 to
5bc9ca5
Compare
Related
What
This adds options (to the SDK and CLI) to control the replay behavior of the gRPC proxy server.
The default is (like before) to replay the oldest data first, and then start relaying live data.
But now you can opt-in to getting the live data first, and afterwards getting the historical data starting with the newest.
TODO