Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Sep 8, 2025

Related

What

Mostly applicable to dataplatform links. But also works (more limited) with http sourced recordings.

image

TODO:

  • finalize layout/design/stuff
  • add image comp test for the new dialog
  • test some more

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself include in changelog labels Sep 8, 2025
@Wumpf Wumpf changed the title New link sharing dialog New link sharing dialog for detailed link sharing Sep 8, 2025
Copy link

github-actions bot commented Sep 8, 2025

Web viewer built successfully.

Result Commit Link Manifest
e94bdda https://rerun.io/viewer/pr/11137 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf added the dataplatform Rerun Data Platform integration label Sep 8, 2025
@Wumpf Wumpf marked this pull request as ready for review September 12, 2025 16:10
@IsseW IsseW self-requested a review September 12, 2025 16:18
Copy link
Member

@gavrelina gavrelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also left a review! mostly non critical, except adding a bit of extra spacing :)

Copy link
Member

@IsseW IsseW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code wise, noticed some things

@Wumpf Wumpf dismissed gavrelina’s stale review September 15, 2025 13:56

I showed an updated picture on Slack and it got @gavrelina's blessing :)

@Wumpf Wumpf merged commit 3c88bd3 into main Sep 15, 2025
72 of 73 checks passed
@Wumpf Wumpf deleted the andreas/link-share-dialog branch September 15, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataplatform Rerun Data Platform integration include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add share button with "link builder" for creating dataplatform links
3 participants