-
Notifications
You must be signed in to change notification settings - Fork 539
New link sharing dialog for detailed link sharing #11137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also left a review! mostly non critical, except adding a bit of extra spacing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good code wise, noticed some things
I showed an updated picture on Slack and it got @gavrelina's blessing :)
Related
What
Mostly applicable to dataplatform links. But also works (more limited) with http sourced recordings.
TODO: