Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix table UI not saying switch to when opening a certain links #11237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

Fix table UI not saying switch to when opening a certain links #11237

merged 1 commit into from
Sep 17, 2025

Conversation

IsseW
Copy link
Member

@IsseW IsseW commented Sep 16, 2025

Related

Closes #11196

What

Fixes a bug where recordings opened with links that had time selection or fragments didn't show as "Switch To" or loading in the table.

@IsseW IsseW added 🪳 bug Something isn't working ui concerns graphical user interface 📺 re_viewer affects re_viewer itself dataplatform Rerun Data Platform integration labels Sep 16, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2025 •
edited
Loading

Web viewer built successfully.

Result Commit Link Manifest
✅ ec5c63f https://rerun.io/viewer/pr/11237 +nightly +main

Note: This comment is updated whenever you push a commit.

Wumpf
Wumpf approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohhh, nice catch

@Wumpf Wumpf merged commit 4fd5eec into main Sep 17, 2025
49 of 54 checks passed
@Wumpf Wumpf deleted the isse/fix-link-switch-to-display branch September 17, 2025 06:21
@Wumpf Wumpf added the consider-patch PRs & issues that should be considered to be cherry-picked to a patch release branch. label Sep 18, 2025
Wumpf pushed a commit that referenced this pull request Sep 18, 2025
@IsseW @Wumpf
Fix table UI not saying switch to when opening a certain links (#11237)
f154544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working consider-patch PRs & issues that should be considered to be cherry-picked to a patch release branch. dataplatform Rerun Data Platform integration include in changelog 📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recordings opened links don't say "switch to" in the table
2 participants
@IsseW @Wumpf