Fix some menu buttons closing unexpectedly #11247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
Wumpf
approved these changes
Sep 17, 2025
There was a problem hiding this comment.
Maybe we should change the default to be always true though?
I feel like usually you want to always show buttons, unless every list item has it (e.g. visibility in the blueprint tree) where it would add too much noise / use too much space.
agreed! but it's probably also good to keep this iteration more minimal? 🤔
a bit shocking that none of our image comparison tests triggers on this change. Strange!
Can be a separate PR, but it would be nice to also fix the formatting here:
(this was called out in the same issue, but more as a sidenote)
Wumpf
pushed a commit
that referenced
this pull request
Sep 18, 2025
### Related * Closes #11245 ### What Changes the default for `should_always_show_buttons` to true when adding a menu button. Maybe we should change the default to be always true though? I feel like usually you want to always show buttons, unless every list item has it (e.g. visibility in the blueprint tree) where it would add too much noise / use too much space. When I worked on the new ItemButtons, I defaulted to false since that was the default in LabelContent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Changes the default for
should_always_show_buttonsto true when adding a menu button.Maybe we should change the default to be always true though?
I feel like usually you want to always show buttons, unless every list item has it (e.g. visibility in the blueprint tree) where it would add too much noise / use too much space.
When I worked on the new ItemButtons, I defaulted to false since that was the default in LabelContent.