Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add entry id to resolve api update (Fix Vector Search) #11259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 17, 2025
Merged

Add entry id to resolve api update (Fix Vector Search) #11259

merged 4 commits into from
Sep 17, 2025

Conversation

ntjohnson1
Copy link
Member

Related

Our vector search on the cloud is broken because we aren't adding the entry id to the header.
https://rerunio.slack.com/archives/C07T0LFT5BQ/p1758117346508129?thread_ts=1758115910.966309&cid=C07T0LFT5BQ

What

Adds an entry id to the header.

Repro to confirm the fix:

  • Enable cloud credentials
client = rr.catalog.CatalogClient(CATALOG_URL)
dataset = client.get_dataset_entry(name=DATASET)

import numpy as np
embedding_column = rr.dataframe.ComponentColumnSelector("/camera/wrist/embedding", "embeddings")
search_results = dataset.search_vector(np.zeros((768,)), embedding_column, top_k=1000).df()
print(f"Found {search_results.count()} with similar images")
search_results

@ntjohnson1 ntjohnson1 added include in changelog dataplatform Rerun Data Platform integration consider-patch PRs & issues that should be considered to be cherry-picked to a patch release branch. labels Sep 17, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2025 •
edited
Loading

Web viewer built successfully.

Result Commit Link Manifest
✅ e30acad https://rerun.io/viewer/pr/11259 +nightly +main

Note: This comment is updated whenever you push a commit.

@ntjohnson1 ntjohnson1 added the 🪳 bug Something isn't working label Sep 17, 2025
@ntjohnson1 ntjohnson1 changed the title Add entry id to resolve api update Add entry id to resolve api update (Fix Vector Search) Sep 17, 2025
@Wumpf Wumpf merged commit e28751c into main Sep 17, 2025
41 checks passed
@Wumpf Wumpf deleted the nick/fix_vector_search branch September 17, 2025 16:46
Wumpf pushed a commit that referenced this pull request Sep 18, 2025
@ntjohnson1 @Wumpf
Add entry id to resolve api update (Fix Vector Search) (#11259)
2ddc623
@Wumpf Wumpf added the 🦟 regression A thing that used to work in an earlier release label Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working consider-patch PRs & issues that should be considered to be cherry-picked to a patch release branch. dataplatform Rerun Data Platform integration include in changelog 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ntjohnson1 @jleibs @Wumpf