Add - formatting option for redacted values
#11383
Merged
+37
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully.
Note: This comment is updated whenever you push a commit. |
1 task
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a - formatting option for redacted values in RecordBatch-derived structs to support snapshot testing with non-deterministic values. The change allows using {:-} format specifier to get string representations with redacted non-deterministic content like TUIDs.
- Updates
Displayimplementations to pass thesign_minus()flag to formatting functions - Modifies
format_record_batch_with_widthto accept aredact_non_deterministicparameter - Removes custom redaction wrapper structs in favor of the new formatting option
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/store/re_format_arrow/src/lib.rs | Adds redact_non_deterministic parameter to format_record_batch_with_width function |
| crates/store/re_chunk/src/chunk.rs | Updates Display impl to pass f.sign_minus() for redaction control |
| crates/store/re_sorbet/src/sorbet_batch.rs | Updates Display impl to pass f.sign_minus() for redaction control |
| crates/store/re_sorbet/src/chunk_batch.rs | Updates Display impl to pass f.sign_minus() for redaction control |
| crates/store/re_dataframe/src/query.rs | Updates test helper to pass f.sign_minus() for redaction control |
| crates/store/re_chunk/tests/formatting.rs | Removes custom ChunkRedacted wrapper and uses new - format option |
| crates/utils/re_mcap/src/layers/protobuf.rs | Removes custom ChunkRedacted wrapper and uses new - format option |
| crates/utils/re_mcap/Cargo.toml | Removes unused re_format_arrow dev dependency |
| CODE_STYLE.md | Documents the new - formatting option convention |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
emilk
approved these changes
Oct 2, 2025
emilk
reviewed
Oct 2, 2025
grtlr
added a commit
that referenced
this pull request
Oct 2, 2025
### Related * Post-merge comment: #11383 (comment) ### What See comment linked above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
RecordBatchwith redactions for non-deterministic values #11278.What
This PR allows you to use the minus sign (
-) formatting option in mostRecordBatch-derived structs to get a string that has non-deterministic values redacted.Usage:
Using
#instead of-would be an alternative, but I think it's better to reserve this for a more meaningful representation.