-
Notifications
You must be signed in to change notification settings - Fork 539
Direct API for setting blueprint on a notebook-embedded viewer #9804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
emilk
approved these changes
Apr 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I don't want to merge this before we have a test for it (even a manual one)
4 tasks
Co-authored-by: Emil Ernerfeldt <[email protected]>
emilk
added a commit
that referenced
this pull request
Apr 25, 2025
### What This is a more ergonomic approach to using #9506 for blueprints. This lets you use Blueprint objects directly without needing to save out to `.rbl` files. Example: ``` blueprint = rrb.Spatial3DView(contents="/**") viewer = rr.notebook.Viewer(width=1350, height=800, url="rerun+http://localhost:51234") viewer.set_application_blueprint("DROID", blueprint) viewer.display() ``` --------- Co-authored-by: Antoine Beyeler <[email protected]> Co-authored-by: Antoine Beyeler <[email protected]> Co-authored-by: Emil Ernerfeldt <[email protected]>
Merged
abey79
added a commit
that referenced
this pull request
Apr 25, 2025
Fixes ci error introduced by: * #9804
emilk
pushed a commit
that referenced
this pull request
Apr 25, 2025
Fixes ci error introduced by: * #9804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is a more ergonomic approach to using #9506 for blueprints.
This lets you use Blueprint objects directly without needing to save out to
.rbl
files.Example: