Add draw order to video (-frame-reference), fix 2d objects sometimes being behind videos #9946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Wumpf
commented
May 9, 2025
| pub const DEFAULT_DEPTH_IMAGE: Self = Self(Float32(-20.0)); | ||
|
|
||
| /// Draw order used for images if no draw order was specified. | ||
| pub const DEFAULT_VIDEO_FRAME_REFERENCE: Self = Self(Float32(-15.0)); |
There was a problem hiding this comment.
figured between depth and images makes sense - it's still like an image but if there is also an image it should show on top
🤷
emilk
approved these changes
May 9, 2025
jprochazk
pushed a commit
that referenced
this pull request
May 24, 2025
…being behind videos (#9946)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Adds a draw order to video assets which also fixes issues with bounding boxes sometimes not showing correctly on top of videos.
(Commit-by-commit friendly PR; but most of it is gen'ed, it's a simple one :))