Fix MSVC C++20 compilation issues #9951
Merged
+50
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes default arguments from `from_loggable` since they caused static assertions to trigger during overload resolve already.
50c59c2 to
e813b79
Compare
e813b79 to
84d21f3
Compare
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
84d21f3 to
c012aa5
Compare
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/14949101803 |
emilk
approved these changes
May 11, 2025
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/14954315744 |
|
CI failure is also there on |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/14992832936 |
|
main ci didn't run the C++ tests, something is still wrong with the C++ ci? |
|
#9992 could help. let's see |
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/15108650937 |
|
that did the trick! :) |
jprochazk
pushed a commit
that referenced
this pull request
May 24, 2025
Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Removes default arguments from
from_loggablesince they caused static assertions to trigger during overload resolvealready. This is technically a breaking change in the interface but I wouldn't feel bad about bending semvar and shipping it in a 0.23.3 release!
Added C++20 MSVC test run to CI. All C++20 tests run now on main/nightly only, not on every pr (starts getting too much)