Deprecate bs-dependencies and bs-dev-dependencies
#7658
Conversation
35d577b to
b4fdc3a
Compare
use initialization logic instead of serde
d55428c to
1bd6371
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
|
This is great! Thanks a lot for your work! Could you maybe also include the |
|
Reminder that this needs to be updated in other tools that use the config file as well. Editor tooling is one, maybe the only one. Maybe we could have a look at having rewatch supply the needed build state from these things to whoever needs them, like the editor tooling. |
rewatch/src/build/packages.rs
Outdated
| jsx: None, | ||
| gentype_config: None, | ||
| namespace_entry: None, | ||
| config: super::config::tests::create_config( |
There was a problem hiding this comment.
not sure I love this, going from a named struct to positional args. The struct creation is a bit verbose, but I don't mind it too much since it's explicit.
There was a problem hiding this comment.
It's just a test method tho. And it does not work otherwise because I introduced private fields
There was a problem hiding this comment.
We could pass a wrapper struct around the arguments.
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| pub mod tests { |
There was a problem hiding this comment.
why does this need to be public?
There was a problem hiding this comment.
See the comment above
| DEPRECATION_REGISTRY.get_or_init(|| Mutex::new(AHashSet::new())) | ||
| } | ||
|
|
||
| pub fn log_deprecated_field(field_name: &str, replacement_field_name: &str, file_path: &PathBuf) { |
There was a problem hiding this comment.
I don't think we need global state for this since it's already in the config struct. We can just log them out when we log all warnings.
There was a problem hiding this comment.
Are warnings only logged once? I needed a mechanism to only log once per config file.
There was a problem hiding this comment.
And can you please show me where we log all warnings?
| @@ -1,4 +1,10 @@ | |||
| Cleaned 0/15 | |||
| WARN: | |||
There was a problem hiding this comment.
We shouldn't prepend this with WARN:
There was a problem hiding this comment.
This comes from the macro. Is there another logging mechanism?
Fixes a part of #7455
bs-dependenciesandbs-dev-dependencies