feat: support logs endpoints#899
Merged
Merged
Conversation
Add resend.logs.list() and resend.logs.get() methods for retrieving API request logs, matching the public API's GET /logs and GET /logs/:logId.
commit: |
Contributor
There was a problem hiding this comment.
1 issue found across 8 files
Confidence score: 4/5
- This PR is likely safe to merge, with one moderate policy/compliance concern rather than a clear runtime regression risk.
- In
src/logs/logs.spec.ts, API-key literals in tests should be replaced with a clearly redacted dummy constant to avoid normalizing secret-like values in repository artifacts. - Given the issue is severity 5/10 and confined to test code, risk to production behavior appears limited, but it is still worth cleaning up promptly.
- Pay close attention to
src/logs/logs.spec.ts- replace literal API-key values with redacted/dummy constants to align with secret-handling expectations.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/logs/logs.spec.ts">
<violation number="1" location="src/logs/logs.spec.ts:45">
P2: Avoid committing API-key literals in tests; replace with a clearly redacted/dummy value sourced from a constant.
(Based on your team's feedback about redacting secrets in test artifacts.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
vcapretz
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.