Fix potential vulnerable cloned function#7189
Open
npt-1707 wants to merge 1 commit intorethinkdb:mainfrom
Open
Fix potential vulnerable cloned function#7189npt-1707 wants to merge 1 commit intorethinkdb:mainfrom
npt-1707 wants to merge 1 commit intorethinkdb:mainfrom
Conversation
Contributor
|
Thank you for the PR. Because we only use this library for an HTTP client, making requests, I don't think there is any security issue at hand. Despite this I think we could stand to upgrade http_parser.cc (and .hpp) to an up-to-date version from Node, maybe, instead of this one patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our tool identified a potential vulnerability in clone functions in
src/http/http_parser.ccsourced from nodejs/http-parser. These issues, originally reported in CVE-2019-15605, were resolved in the repository via this commit nodejs/http-parser@7d5c99d.This PR applies the corresponding patch to fix the vulnerabilities in this codebase.
Please review at your convenience.
Checklist
added
Signed-off-by: <YOUR NAME>to the commit trail where<YOUR NAME>ismy name.