-
-
Notifications
You must be signed in to change notification settings - Fork 32
Extract python driver #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 90dee95.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All this looks good to merge. Can the proto file be stored in the repo for isolated local development? Maybe with a Travis post build to commit this. Also I would like to see the package names become reql
as they are agnostic.
@grandquista There is a plan to rename the package (and every reference for the package name) but for the first run I would not like to introduce this kind of change. I would like to open a separate PR for the renaming to clearly see what changed. Please note that I disabled flake8 until this PR is merged. I'll open a separate PR for formatting issue fixing. |
Looks like tox doesn't have support for Python3.3 anymore tox-dev/tox/issues/168. I'm good with disabling that one as well. Python3.3 also blocks support for Python3.7 due to |
@grandquista Due to Python 3.3 is end of life since 2017 I remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge
[15055] gzipped json export/import
Description
This PR extends and adjusting the modified python driver for RebirthDB. Due to the driver's files are outdated and I created a "proper" (or at least) package for the driver.
What I've done:
.gitignore
file to exclude python related filesMakefile
to easily manage the package's build and upload.travis.yml
for CI integrationtox
configurationNOTE
Version of the package is already bumped. The reason is that it is not bumped since
2016
.### TODO
In the future we will need to
rethinkdb
package name to rebirthdb while keeping the git historyPyPi