Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Extract python driver #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jul 16, 2018
Merged

Extract python driver #1

merged 24 commits into from
Jul 16, 2018

Conversation

gabor-boros
Copy link
Member

@gabor-boros gabor-boros commented Jul 16, 2018

Description

This PR extends and adjusting the modified python driver for RebirthDB. Due to the driver's files are outdated and I created a "proper" (or at least) package for the driver.

What I've done:

  • Extended the .gitignore file to exclude python related files
  • Created a new Makefile to easily manage the package's build and upload
  • Created .travis.yml for CI integration
  • License added to the root folder and for the touched files
  • Created requirements.txt for easier dependency install
  • Added a dummy test to be able to run on travis
  • Set up tox configuration

NOTE
Version of the package is already bumped. The reason is that it is not bumped since 2016.

### TODO
In the future we will need to

  • Rename rethinkdb package name to rebirthdb while keeping the git history
  • Move the python driver related tests from the original repo
  • Upload new package to PyPi

@gabor-boros gabor-boros added the enhancement New feature or request label Jul 16, 2018
@gabor-boros gabor-boros self-assigned this Jul 16, 2018
@gabor-boros gabor-boros requested review from asakatida and atris July 16, 2018 08:40
asakatida
asakatida previously approved these changes Jul 16, 2018
Copy link

@asakatida asakatida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this looks good to merge. Can the proto file be stored in the repo for isolated local development? Maybe with a Travis post build to commit this. Also I would like to see the package names become reql as they are agnostic.

@gabor-boros
Copy link
Member Author

gabor-boros commented Jul 16, 2018

@grandquista There is a plan to rename the package (and every reference for the package name) but for the first run I would not like to introduce this kind of change. I would like to open a separate PR for the renaming to clearly see what changed.

Please note that I disabled flake8 until this PR is merged. I'll open a separate PR for formatting issue fixing.

@asakatida
Copy link

Looks like tox doesn't have support for Python3.3 anymore tox-dev/tox/issues/168. I'm good with disabling that one as well. Python3.3 also blocks support for Python3.7 due to async keyword.

@gabor-boros
Copy link
Member Author

@grandquista Due to Python 3.3 is end of life since 2017 I remove it.

Copy link

@asakatida asakatida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge

@asakatida asakatida merged commit f0bf3b7 into master Jul 16, 2018
@gabor-boros gabor-boros deleted the adjust-python-driver branch July 16, 2018 18:48
gabor-boros added a commit that referenced this pull request Jul 24, 2018
iantocristian pushed a commit to iantocristian/rethinkdb-python that referenced this pull request Mar 28, 2021
[15055] gzipped json export/import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants