Fixes changes in 3.7 Multiprocessing for Import/Export and dump/restore #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lookup the context and pass it into class initalization of the SimpleQueue - for simplification, follow example patterns of importing multiprocessing as mp - multiprocessing.Queue can cause surprising results which are avoided using a queue manager Manager(). See https://docs.python.org/3.7/library/multiprocessing.html - optparse passes in self to the check_existing_file, so set as _ - optparse calls the callback with many more args then originally setup for. - fix env lookup variables which were missed when rebirthdb merged back with rethinkdb
gabor-boros
previously requested changes
Mar 23, 2019
There was a problem hiding this comment.
@sawdog Could you please add some tests as well to ensure that this functionality will work on both python2.7.x and python 3.x?
rethinkdb/utils_common.py
Outdated
| @@ -207,7 +206,10 @@ def file_contents(opt_str, value): | |||
|
|
|||
| # -- Callbacks | |||
|
|
|||
| def combined_connect_action(value, parser): | |||
| def combined_connect_action(obj, opt, value, parser, *args, **kwargs): | |||
| """optparse.takeaction() calls the callback (which this is set as) | |||
|
@sawdog what’s up with this PR? |
Closed
No need for my own review if I contribute as well
|
@grandquista Although the tests are missing I would like to merge this, due to we will need to refactor the whole code (optparse is buggy and deprecated in favor of argparse). Could you check this please? |
Closed
asakatida
approved these changes
Apr 21, 2019
| with open("rethinkdb/version.py", "w") as f: | ||
| f.writelines([ | ||
| "# Autogenerated version", | ||
| "VERSION = {0}".format(VERSION) |
|
When does this get commited to pypi? |
|
@Sharpz7 It’s already on PyPi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear what's happened with the original pull request, but I was using this to import/export from databases I was running - I see that there's a new bug on that just filed 3 days ago?