Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix StopIteration exception related issue #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2019
Merged

Fix StopIteration exception related issue #115

merged 3 commits into from
Apr 26, 2019

Conversation

gabor-boros
Copy link
Member

@gabor-boros gabor-boros commented Apr 25, 2019 •
edited
Loading

Reason for the change
#110

Description
Due to PEP 479 StopIteration handling inside generators. This change fixes the "issue" by returning if a stop iteration raised.

Code examples

Python 3.7.3 (default, Mar 27 2019, 09:23:15) 
[Clang 10.0.1 (clang-1001.0.46.3)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from rethinkdb import r
>>> r.now()
<RqlQuery instance: r.now() >

Checklist

  • Unit tests created/modified
  • Integration tests created/modified

References
https://www.python.org/dev/peps/pep-0479/

@gabor-boros gabor-boros added the bug Something isn't working label Apr 25, 2019
@gabor-boros gabor-boros added this to the Release 2.4.2 milestone Apr 25, 2019
@gabor-boros gabor-boros self-assigned this Apr 25, 2019
@gabor-boros gabor-boros changed the title Fix StopIteration exception Fix StopIteration exception related issue Apr 25, 2019
@rethinkdb rethinkdb deleted a comment Apr 26, 2019
@gabor-boros gabor-boros requested a review from asakatida April 26, 2019 08:36
@asakatida asakatida merged commit efd62ee into master Apr 26, 2019
@gabor-boros gabor-boros deleted the fix/stop-iteration-exception branch August 30, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asakatida asakatida asakatida approved these changes

Assignees

@gabor-boros gabor-boros

Labels
bug Something isn't working
Projects
None yet
Milestone
Release 2.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@gabor-boros @asakatida