Fix write-hook compatiblity for 2.3.6 (import/export) #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disable export of write-hooks
… disable import of write-hooks
gabor-boros
approved these changes
Aug 21, 2019
|
Thank you for your PR 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the change
Write-hooks is the only feature that blocks usage of dump/import/export commands of newest rethinkdb drivers with database version
2.3.6although it's easy to make that backward-compatibleDescription
It is needed to check minimal database version and if lower than
2.3.7then disable reading/writing of write-hooks during export/import.