Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix StopIteration in the case of EOF (import/restore) #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

alexa-infra
Copy link
Contributor

Reason for the change
Import/restore doesn't work without this patch

Description
The proper way is return, not raise StopIteration.

References
https://www.python.org/dev/peps/pep-0479/

Copy link
Member

@gabor-boros gabor-boros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gabor-boros gabor-boros merged commit a3aa88e into rethinkdb:master Aug 21, 2019
@alexa-infra alexa-infra deleted the fix-import-eof-check branch September 2, 2019 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants