Fix bug in Trio's _read_exactly()
#213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method calls Trio's `receive_some(n)`, which I found out can actually return fewer than `n` bytes. This is only noticeable on large messages (query results of around 80KB triggered the issue). The solution is to call `receive_some(...)` in a loop until `n` bytes has been received.
gabor-boros
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the change
The
_read_exactly()method in the Trio driver sometimes fails on large responses, such as query results that contain lots of data.Description
This method calls Trio's
receive_some(n), which I found out can actuallyreturn fewer than
nbytes. This is only noticeable on large messages(query results of around 80KB triggered the issue). The solution is to call
receive_some(...)in a loop untilnbytes has been received.Code examples
n/a
Checklist
References
n/a