Simplify integration tests #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description Adding functionality to the logger to be able to write to stdout/stderr. This feature was requested in https://github.com/RebirthDB/rebirthdb-python/pull/9/files/8328cc1a20e57615da7163cd50148e5042741bdc#diff-565263873ac3f2f37ce9d01ee9bd638a
Description Integration tests containes unused variables and other, not needed stuff, like `teardown_methods`. Note: Tear down methods are not needed in most of the cases, due to we are removing the DB itself at the end of every test.
asakatida
suggested changes
Aug 26, 2018
tests/integration/test_database.py
Outdated
| self.test_db_name = 'test_database' | ||
|
|
||
| def teardown_method(self): | ||
| self.conn.close() |
|
I am starting traveling and will be unavailable for a significant portion of time this week. Feel free to self merge this after the one fix. |
|
@grandquista, your comment was addressed. |
asakatida
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integration tests containes unused variables and other, not needed stuff, like
teardown_methods.Note: Tear down methods are not needed in most of the cases, due to we are removing the DB itself at the end of every test.