Added write lock mechanizim around controller reuse #1551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We'll defer this for the next release pending testing. We need to at least have a manual test to verify this fix resolves the issue. To reproduce, we need to force a concurrent access to the |
4fc7d52 to
57caf1d
Compare
wiselike
pushed a commit
to wiselike/revel
that referenced
this pull request
Apr 5, 2024
hengwu0
reviewed
Apr 7, 2024
Comment on lines
+232
to
+233
| } else { | ||
| RevelLog.Warn("Failed to unpack json file", "error", err, "Json", inputmode) |
There was a problem hiding this comment.
It should not raise a warning here. Because it said "The input mode can be as simple as "prod" or it can be a JSON string" before. This code should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added write lock mechanizim around controller reuse
closes #1547