Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@marconi
Copy link
Contributor

@marconi marconi commented Aug 28, 2013

No description provided.

@mclark4386
Copy link

I'll test this later, but I can see this example being very useful and since there is a twitter and a FB one already I see no reason not to have it, but it's up to Rob in the end^^;

@marconi
Copy link
Contributor Author

marconi commented Sep 9, 2013

Yep, no worries though, I just thought someone would find this useful. Cheers! ;)

@marconi
Copy link
Contributor Author

marconi commented Sep 9, 2013

Or you can clone my revel fork at https://github.com/marconi/revel.git and run the persona project under samples.

On Tuesday, September 10, 2013 at 7:08 AM, Matthew Clark wrote:

is there an easy way to gen a diff of this so I can test it? I would very much like to try the sample because I can see it being helpful!^^


Reply to this email directly or view it on GitHub (https://github.com/robfig/revel/pull/288#issuecomment-24122148).

@mclark4386
Copy link

after I login it goes into an infinite loop saying: Login successful: and refreshing.

@marconi
Copy link
Contributor Author

marconi commented Sep 10, 2013

that's what happens when you don't set a host, see the controller:

const host = ""

@mclark4386
Copy link

lol gotcha, may bad

@mclark4386
Copy link

boom, that got it^^

@marconi
Copy link
Contributor Author

marconi commented Sep 10, 2013

👍

@mclark4386
Copy link

There needs to be a way to "+1" pull requests^^ Hear that GitHub? Get on it! =P

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is not supposed to be a space in the json tag -- json:"status"

@robfig
Copy link
Contributor

robfig commented Sep 15, 2013

This looks great, thanks for the hard work! Just had a few comments, but nothing big.

@marconi
Copy link
Contributor Author

marconi commented Sep 15, 2013

Updated the pull request, cheers!

@robfig
Copy link
Contributor

robfig commented Sep 16, 2013

Thanks!

robfig added a commit that referenced this pull request Sep 16, 2013
add sample project with persona authentication
@robfig robfig merged commit 1193d07 into revel:master Sep 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants