Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Receive chunked responses to get around max payload limit #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jwietelmann merged 2 commits into from
Nov 15, 2018
Merged

Receive chunked responses to get around max payload limit #4

jwietelmann merged 2 commits into from
Nov 15, 2018
+61 −7

Conversation

@jwietelmann
Copy link
Contributor

@jwietelmann jwietelmann commented Nov 15, 2018 •
edited
Loading

fixes #2

When the response is larger than Port can handle, the JS server will send it in chunks. NodeJS.Worker will stitch the chunks together until it reaches a newline, at which point it will finally return the complete decoded payload.

Also...

This will be version 1.0.0. 🎊

@coveralls
Copy link

coveralls commented Nov 15, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 34

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.8%) to 90.0%
Totals Coverage Status
Change from base Build 28: 1.8%
Covered Lines: 36
Relevant Lines: 40
💛 - Coveralls

@jwietelmann jwietelmann changed the title [DO NOT MERGE] Receive chunked responses to get around max payload limit Receive chunked responses to get around max payload limit Nov 15, 2018
@jwietelmann jwietelmann requested a review from bryanjos November 15, 2018 18:48
@jwietelmann jwietelmann requested a review from prehnRA November 15, 2018 18:55
bryanjos
bryanjos approved these changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@bryanjos bryanjos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@jwietelmann jwietelmann merged commit f9d9c14 into master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prehnRA prehnRA Awaiting requested review from prehnRA

1 more reviewer

@bryanjos bryanjos bryanjos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JS function calls fail when returning JSON is larger than 65536 bytes

4 participants

@jwietelmann @coveralls @bryanjos