Add kubernetes provisioner and provisioner set support #3818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lets resolve the conflicts and push the latest changes. |
begelundmuller
requested changes
Feb 9, 2024
There was a problem hiding this comment.
This PR looks very good! Put some comments below, apart from those, one other question – could we put some instructions for testing the Kubernetes provisioner in a README.md in the admin/provisioner directory. Optionally (I realize this might not be worth the trouble), could also add a test somewhere for the Kubernetes provisioner that starts Minikube using Testcontainers.
begelundmuller
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the
provisionerpackage to support multiple provisioners and adds a new Kubernetes provisioner type to dynamically provision runtimes.