-
Notifications
You must be signed in to change notification settings - Fork 129
Init Runtime Store #4519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init Runtime Store #4519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, should be okay now. The types kind of threw me off. For my own sanity, I'll try to explain the host behavior. In Rill developer, the host should be In web-admin, there's another httpClient for the admin service that uses Axios. It runs on web-admin also uses the runtime service, but the host is conditional based on the project and no calls should be made to it until you have a host and instance id. However, the layout does have hooks like |
This PR initializes the runtime store with default values and, in Rill Developer, removes the use of the RuntimeProvider component, which is not necessary.
Additionally, it cleans up the process by which we derive the runtime URL.
This is a necessary change to enable data fetching in
+
files as the http-client requires that runtime be defined.