Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(canvas): row item limit #7197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 22, 2025
Merged

fix(canvas): row item limit #7197

merged 7 commits into from
Apr 22, 2025

Conversation

briangregoryholmes
Copy link
Contributor

Max 4 items allowed per row.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Copy link

Repository not enabled for automatic review

The Bito agent is set up, but this repository is not enabled for automatic code reviews. To review this pull request, type /review in a comment and save it.

You can enable automatic reviews in the agent setup here or contact your Bito workspace admin at [email protected].

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration
This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

@briangregoryholmes briangregoryholmes changed the title Bgh/canvas fix fix(canvas): row item limit Apr 22, 2025
@briangregoryholmes briangregoryholmes added patch Type:Bug Something isn't working labels Apr 22, 2025
Copy link
Contributor

@lovincyrus lovincyrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally :shipit:

@djbarnwal
Copy link
Member

Looks good. Although when I have a row with 4 items, I wasn't able to drag and swap items in the same row. Is that intentional?

@briangregoryholmes briangregoryholmes merged commit e64e51d into main Apr 22, 2025
9 checks passed
@briangregoryholmes briangregoryholmes deleted the bgh/canvas-fix branch April 22, 2025 19:04
briangregoryholmes added a commit that referenced this pull request Apr 22, 2025
* fix(canvas): pivot cell interactivity

* fix: max item count

* fix: swapping items within a row

* fix: break instead of return
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants