Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert concurrent writes in duckdb #7209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2025
Merged

Revert concurrent writes in duckdb #7209

merged 2 commits into from
Apr 23, 2025

Conversation

k-anshul
Copy link
Member

@k-anshul k-anshul commented Apr 23, 2025 •
edited
Loading

Facing some race condition wrt wal file deletion in duckdb on concurrent writes.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@k-anshul k-anshul self-assigned this Apr 23, 2025
@bito-code-review Bito Code Review
Copy link

Repository not enabled for automatic review

The Bito agent is set up, but this repository is not enabled for automatic code reviews. To review this pull request, type /review in a comment and save it.

You can enable automatic reviews in the agent setup here or contact your Bito workspace admin at [email protected].

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

Refer to the documentation for additional commands.

Configuration
This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

@k-anshul k-anshul requested a review from begelundmuller April 23, 2025 16:49
@k-anshul k-anshul assigned grahamplata and unassigned grahamplata Apr 23, 2025
@k-anshul k-anshul requested a review from grahamplata April 23, 2025 16:49
@k-anshul k-anshul merged commit 102cfd7 into main Apr 23, 2025
14 of 15 checks passed
@k-anshul k-anshul deleted the revert_concurrent_writes branch April 23, 2025 17:25
k-anshul added a commit that referenced this pull request Apr 23, 2025
@k-anshul
Revert concurrent writes in duckdb (#7209)
40b6c4c 
* Revert "run an explicit checkpoint command before detach (#7185)"

This reverts commit 48d544f.

* Revert "feat : Support concurrent write queries in duckdb driver (#7109)"

This reverts commit 137c7c0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamplata grahamplata grahamplata approved these changes

@begelundmuller begelundmuller Awaiting requested review from begelundmuller

Assignees

@k-anshul k-anshul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-anshul @grahamplata