Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix race condition when parser refresh and model refresh run concurrently #7210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

begelundmuller
Copy link
Contributor

This problem surfaced due to a recent change that makes the rill project refresh trigger parser refreshes in addition to the usual source and model refreshes.

The problem is that the parser always writes model specs with trigger == false, which may override a concurrent refresh trigger that has just set trigger = true.

I will add tests to cover this issue in a follow up PR.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@begelundmuller begelundmuller requested a review from k-anshul April 23, 2025 17:17
@begelundmuller begelundmuller self-assigned this Apr 23, 2025
@rilldata rilldata deleted a comment from bito-code-review bot Apr 23, 2025
@begelundmuller begelundmuller merged commit 9f7846e into main Apr 23, 2025
15 checks passed
@begelundmuller begelundmuller deleted the begelundmuller/fix-parser-model-refresh-race-condition branch April 23, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants