Fix race condition when parser refresh and model refresh run concurrently #7210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem surfaced due to a recent change that makes the
rill project refresh
trigger parser refreshes in addition to the usual source and model refreshes.The problem is that the parser always writes model specs with
trigger == false
, which may override a concurrent refresh trigger that has just settrigger = true
.I will add tests to cover this issue in a follow up PR.
Checklist: