Apply smart refetchInterval to all resource tables
#7216
Conversation
refetchIntervalInBackground to all resource tablesrefetchIntervalInBackground to all resource tables
There was a problem hiding this comment.
However, for dashboards, reports, and alerts tables, this approach isn't required
For dashboards especially, we would like to poll the ListResources API when the resource has not finished reconciling. This will particularly help the UX when deploying projects (see my comment in the setup.ts file).
|
Additionally, mind updating the PR description? |
refetchIntervalInBackground to all resource tablesrefetchInterval to all resource tables
| refetchInterval: (query) => { | ||
| const newInterval = calculateRefetchInterval( | ||
| currentRefetchInterval, | ||
| query.state.data, | ||
| query, | ||
| ); | ||
| if (newInterval === false) { | ||
| currentRefetchInterval = INITIAL_REFETCH_INTERVAL; | ||
| return false; | ||
| } | ||
| currentRefetchInterval = newInterval; | ||
| return newInterval; | ||
| }, |
There was a problem hiding this comment.
Tracking state outside of the calculateRefetchInterval function makes this more complex than it feels like it should be. I'm wondering if there's a way calculateRefetchInterval could encompass all of the logic, so we could call it like this:
query: {
...
refetchInterval: calculateRefetchInterval // more descriptive name could be something like `pollUntilResourcesReconciled`
}
One idea, could we add custom state to either query.meta or query.state, e.g. query.state.currentRefetchInterval = X?
There was a problem hiding this comment.
Agreed that we should keep the refetchInterval state encapsulated within the component.
Closes #6667
In this pull request, we introduced a custom refetch interval to repeatedly reload a resource until its status was marked as complete. That same custom refetch interval is being applied to dashboards, alerts, and reports.
Checklist: