feat: improve canvas chart legend #7223
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Review Agent Run #109c17Actionable Suggestions - 2
Review Details
AI Code Review powered by |
Comment on lines
+24
to
37
| function updateFieldConfig(property: keyof FieldConfig, value: any) { | ||
| if (typeof markConfig !== "string") { | ||
| const updatedConfig: FieldConfig = { | ||
| ...markConfig, | ||
| [property]: value, | ||
| }; | ||
| onChange(updatedConfig); | ||
| } else if (property === "field") { | ||
| onChange({ | ||
| field: value, | ||
| type: "nominal", | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
Missing case handling in updateFieldConfig function
The updateFieldConfig function has been refactored to handle both string and object types for markConfig, but the implementation creates a potential issue when property is not 'field' and markConfig is a string. This case isn't handled, which could lead to unexpected behavior.
Code suggestion
Check the AI-generated fix before applying
Suggested change
| function updateFieldConfig(property: keyof FieldConfig, value: any) { | |
| if (typeof markConfig !== "string") { | |
| const updatedConfig: FieldConfig = { | |
| ...markConfig, | |
| [property]: value, | |
| }; | |
| onChange(updatedConfig); | |
| } else if (property === "field") { | |
| onChange({ | |
| field: value, | |
| type: "nominal", | |
| }); | |
| } | |
| } | |
| function updateFieldConfig(property: keyof FieldConfig, value: any) { | |
| if (typeof markConfig !== "string") { | |
| const updatedConfig: FieldConfig = { | |
| ...markConfig, | |
| [property]: value, | |
| }; | |
| onChange(updatedConfig); | |
| } else if (property === "field") { | |
| onChange({ | |
| field: value, | |
| type: "nominal", | |
| }); | |
| } else { | |
| // Handle case where property is not 'field' but markConfig is a string | |
| console.warn(`Cannot update ${property} when markConfig is a string`); | |
| } | |
| } |
Code Review Run #109c17
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
Comment on lines
+55
to
74
| interface NominalFieldConfig { | ||
| sort?: ChartSortDirection; | ||
| limit?: number; | ||
| showNull?: boolean; | ||
| labelAngle?: number; | ||
| legendOrientation?: ChartLegend; | ||
| } | ||
|
|
||
| interface QuantitativeFieldConfig { | ||
| zeroBasedOrigin?: boolean; // Default is false | ||
| } | ||
|
|
||
| export interface FieldConfig | ||
| extends NominalFieldConfig, | ||
| QuantitativeFieldConfig { | ||
| field: string; | ||
| type: "quantitative" | "ordinal" | "nominal" | "temporal"; | ||
| showAxisTitle?: boolean; // Default is false | ||
| timeUnit?: string; // For temporal fields | ||
| } |
There was a problem hiding this comment.
Property moved to type-specific interface restricts usage
The FieldConfig interface has been refactored into separate interfaces with specific properties, but zeroBasedOrigin is now only in QuantitativeFieldConfig which may cause issues when used with non-quantitative field types.
Code suggestion
Check the AI-generated fix before applying
@@ -63,12 +63,13 @@
+
+interface QuantitativeFieldConfig {
-+ zeroBasedOrigin?: boolean; // Default is false
+}
+
+export interface FieldConfig
+ extends NominalFieldConfig,
+ QuantitativeFieldConfig {
+ field: string;
+ type: "quantitative" | "ordinal" | "nominal" | "temporal";
+ showAxisTitle?: boolean; // Default is false
++ zeroBasedOrigin?: boolean; // Default is false
+ timeUnit?: string; // For temporal fields
Code Review Run #109c17
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add multiple improvements to chart legends -
Checklist: