fix (Exports): Simplify time ranges for on-demand exports #7241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timeEnd for "latest" time ranges
briangregoryholmes
approved these changes
May 1, 2025
AdityaHegde
approved these changes
May 1, 2025
ericpgreen2
added a commit
that referenced
this pull request
May 1, 2025
* Only set explicit `timeEnd` for "latest" time ranges * Simpler. Just use `startTime` and `endTime` from `timeControlsStore`.
grahamplata
pushed a commit
that referenced
this pull request
May 8, 2025
* Only set explicit `timeEnd` for "latest" time ranges * Simpler. Just use `startTime` and `endTime` from `timeControlsStore`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we provide time ranges to the
ExportAPI for on-demand (non-scheduled) exports.Previously, we provided a time range expression (e.g.
P7D,rill-MTD) and amended it by also specifying anendDate. (This amendment attempted to ensure consistency with the data shown in the UI, but the approach was faulty).Now, we pass in the
startTimeandendTimefrom thetimeControlsStore. Currently, thetimeControlsStoreresolves time range expressions client-side. However, in the future, we should use the backend'sMetricsViewTimeRangesAPI to resolve time ranges.Closes https://github.com/rilldata/rill-private-issues/issues/1650
Checklist: