Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: deploy journey org selection improvements #7243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat: deploy journey org selection improvements #7243

wants to merge 9 commits into from
+450 −344

Conversation

AdityaHegde
Copy link
Collaborator

@AdityaHegde AdityaHegde commented May 1, 2025 •
edited
Loading

Updates the deploy journey to ask for explicit org name for new users instead of autogenerating using user's email.

Pre-req: #7244 #7262

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde AdityaHegde force-pushed the feat/deploy-org-selection-improvements branch from 07b6270 to cd137b6 Compare May 1, 2025 12:27
@AdityaHegde AdityaHegde force-pushed the feat/deploy-org-selection-improvements branch from e24e09c to ac8465a Compare May 5, 2025 12:32
@AdityaHegde AdityaHegde force-pushed the feat/deploy-org-selection-improvements branch 2 times, most recently from fbc5324 to b005e19 Compare May 6, 2025 05:05
@AdityaHegde AdityaHegde requested a review from ericpgreen2 May 6, 2025 05:06
@AdityaHegde AdityaHegde marked this pull request as ready for review May 6, 2025 05:06
@AdityaHegde AdityaHegde mentioned this pull request May 6, 2025
Draft
8 tasks
@ericpgreen2 ericpgreen2 requested a review from ericokuma May 6, 2025 12:48
@ericpgreen2
Copy link
Contributor

/review

@bito-code-review Bito Code Review
Copy link

bito-code-review bot commented May 6, 2025 •
edited
Loading

Code Review Agent Run #3eca84

Actionable Suggestions - 0
Additional Suggestions - 3
  • web-common/src/components/forms/Input.svelte - 1
    • Missing alignment styling for prepend slot · Line 138-235
  • web-common/src/features/organization/utils.ts - 1
    • Duplicated logic for determining trial status · Line 52-66
  • web-common/src/components/forms/Select.svelte - 1
    • Unused close function creates dead code · Line 56-60
Review Details
  • Files reviewed - 8 · Commit Range: 5a5a39e..b005e19
    • web-common/src/components/forms/Input.svelte
    • web-common/src/components/forms/Select.svelte
    • web-common/src/features/organization/CreateNewOrgForm.svelte
    • web-common/src/features/organization/utils.ts
    • web-common/src/features/project/DeployError.svelte
    • web-common/src/features/project/OrgSelector.svelte
    • web-common/src/features/project/ProjectDeployer.ts
    • web-local/src/routes/(misc)/deploy/+page.svelte
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

AI Code Review powered by Bito Logo

@bito-code-review Bito Code Review
Copy link

Bito Banner

Bito's AI Code Review trial is almost over
Your free trial of Bito's AI Code Reviews was setup by [email protected] and is nearly over. Let them know if you'd like to continue getting complete reviews.

Sign in to upgrade

About Bito
Merge PRs 89% faster, with 34% fewer regressions, and 87% of relevant PR feedback provided by Bito's AI Code Reviews. Trusted by 100,000+ developers and 1,000+ engineering teams.

@AdityaHegde AdityaHegde marked this pull request as draft May 6, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpgreen2 ericpgreen2 Awaiting requested review from ericpgreen2

@ericokuma ericokuma Awaiting requested review from ericokuma

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdityaHegde @ericpgreen2