Thanks to visit codestin.com
Credit goes to github.com

Allow `materialize: true` with `type: dictionary` in ClickHouse models #7247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

k-anshul merged 2 commits into main from begelundmuller/improve-materialize-type-clickhouse

May 7, 2025

Contributor

begelundmuller commented May 1, 2025 •

edited

Loading

It's an easy mistake to make and since dictionaries can be considered a kind of materialization, I think we should just allow it.

Checklist:

Covered by tests
Ran it and it works as intended
Reviewed the diff before requesting a review
Checked for unhandled edge cases
Linked the issues it closes
Checked if the docs need to be updated
Intend to cherry-pick into the release branch
I'm proud of this work!


          Allow materialize: true with type: dictionary in ClickHouse models

3f0efbc

begelundmuller self-assigned this


          Test case

2ce5124

begelundmuller requested a review from k-anshul

May 7, 2025 13:13

k-anshul approved these changes

View reviewed changes

k-anshul merged commit 69cc703 into main

8 of 9 checks passed

k-anshul deleted the begelundmuller/improve-materialize-type-clickhouse branch

May 7, 2025 15:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet