Integration test for redshift #7251
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanMahor
commented
May 1, 2025
| @@ -0,0 +1,48 @@ | |||
| #expensive: true | |||
There was a problem hiding this comment.
I will uncomment it before committing.
k-anshul
requested changes
May 2, 2025
| @@ -240,8 +240,8 @@ type sourceProperties struct { | |||
| OutputLocation string `mapstructure:"output_location"` | |||
| Workgroup string `mapstructure:"workgroup"` | |||
| Database string `mapstructure:"database"` | |||
| ClusterIdentifier string `mapstructure:"cluster.identifier"` | |||
| RoleARN string `mapstructure:"role.arn"` | |||
| ClusterIdentifier string `mapstructure:"cluster_identifier"` | |||
There was a problem hiding this comment.
This will make it backward incompatible. Why is this change necessary ?
There was a problem hiding this comment.
it is mentioned as cluster_identifier and role_arn in SourceProperties which UI uses to generate it yaml.
So I think user were not able to redshift as source unless we told them to use role.arn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #1652
Checklist: