Fix race conditions uncovered with -race #7253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begelundmuller
commented
May 6, 2025
k-anshul
reviewed
May 7, 2025
| // Clone for editing | ||
| tmp := *inst | ||
| inst = &tmp | ||
| inst.ProjectConnectors = projConns | ||
|
|
||
| return r.EditInstance(ctx, inst, false) |
There was a problem hiding this comment.
IMO this entire workflow is somewhat hacky. Ideally EditInstance should take another struct as input and return a new object scanned from DB.
There was a problem hiding this comment.
Agree, not going to fix now, but would be nice to improve the instance management logic
k-anshul
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attaching screenshots of the two race conditions this PR addresses.
Checklist: