Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoid persistent keys in the Connector preview #8213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Avoid persistent keys in the Connector preview #8213

wants to merge 5 commits into from
+29 −4

Conversation

@lovincyrus
Copy link
Contributor

@lovincyrus lovincyrus commented Oct 31, 2025 •
edited
Loading

This PR clears irrelevant auth fields when switching methods, so the preview doesn't retain stale values. Closes https://linear.app/rilldata/issue/APP-510/fix-connector-preview-in-multi-step-form

DEMO

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@lovincyrus lovincyrus self-assigned this Oct 31, 2025
@lovincyrus lovincyrus requested a review from royendo October 31, 2025 07:31
@lovincyrus lovincyrus marked this pull request as ready for review October 31, 2025 08:09
royendo
royendo approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@royendo royendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PROD: Looks good to me! Both HMAC and JSON are cleared when navigating away.

Adding EricG for code review

@royendo royendo requested a review from ericpgreen2 November 4, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericpgreen2 ericpgreen2 ericpgreen2 approved these changes

@royendo royendo royendo approved these changes

Assignees

@lovincyrus lovincyrus

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lovincyrus @ericpgreen2 @royendo