Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@lovincyrus
Copy link
Contributor

@lovincyrus lovincyrus commented Oct 31, 2025

This PR implements the feature to invite guest users with project access selection from org users. Closes https://linear.app/rilldata/issue/APP-229/force-project-access-selection-when-creating-guest-users-at-org-user

CleanShot.2025-10-31.at.17.59.46.mp4

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@lovincyrus lovincyrus self-assigned this Oct 31, 2025
@lovincyrus lovincyrus marked this pull request as ready for review October 31, 2025 10:25
Copy link
Contributor

Thanks Cyrus! Some feedback:

Proposed Changes:

  1. Remove “Guest” as a role option
    Remove the Guest role from the Member Creation page.
  2. Add “Create Guest” functionality
    Introduce a “Create Guest” button on the Guests page.
    • When clicked, users can enter one or more email addresses (comma-separated).
    • Users can then multi-select which projects to grant access to (users must select at least 1 project in order to create guest users)
    • Users must select at least 1 access level for the projects selected. Dropdown selector for access level with options:
      • Admin
      • Editor
      • Viewer (default)

@lovincyrus
Copy link
Contributor Author

Thanks Cyrus! Some feedback:

Proposed Changes:

  1. Remove “Guest” as a role option Remove the Guest role from the Member Creation page.

  2. Add “Create Guest” functionalityIntroduce a “Create Guest” button on the Guests page.

    • When clicked, users can enter one or more email addresses (comma-separated).

    • Users can then multi-select which projects to grant access to (users must select at least 1 project in order to create guest users)

    • Users must select at least 1 access level for the projects selected. Dropdown selector for access level with options:

      • Admin
      • Editor
      • Viewer (default)

Addressed the proposed changes. @ericokuma

@lovincyrus lovincyrus requested a review from ericokuma November 4, 2025 09:39
@ericokuma
Copy link
Contributor

@ericokuma
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants