Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add dashboard chat context support #8217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add dashboard chat context support #8217

wants to merge 5 commits into from

Conversation

@AdityaHegde
Copy link
Collaborator

@AdityaHegde AdityaHegde commented Oct 31, 2025 •
edited
Loading

Adds non-editable dashboard context to chat when in dashboard.
Also includes measure quick explanation feature.

Behind a feature flag: dashboard_chat

TODO

  • Get design feedback on implementation of context in chat.
  • Get design for including context in historical messages.
  • Improve formatting of context items. Filters should be more readable rather than url params format.
  • New messages dont include context because we add the message optimistically, we need to update this based on server response.
  • Context should get cleared when moved out of dashboard.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Di7design
Di7design requested changes Oct 31, 2025
View reviewed changes
Copy link

@Di7design Di7design left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Aditya!
After testing, I noticed the current hover action feels a bit slow if I click the tag without waiting. Can we display the list with the click behavior as well — when clicking the tag, it should both apply the filter and open the list, and clicking anywhere else will close the list. The remove action should only be triggered by the close icon, not by clicking the tag itself.

I also noticed that when I use the Explain feature, it doesn’t update the measure filter in the tag — is this intentional, or is the measure filter missing in this case? Also, when I add a measure filter manually, it doesn’t update in the tag either.
Screenshot 2025-10-31 at 9 23 30 AM

@AdityaHegde
Copy link
Collaborator Author

AdityaHegde commented Nov 3, 2025

Thanks @Di7design . Measure name being in the filter will be a future enhancement. For now we have opted to skip things in the chat being identified as a context item.

@AdityaHegde AdityaHegde force-pushed the feat/dashboard-chat-context branch from 34356ca to 032e99d Compare November 3, 2025 15:05
Di7design
Di7design requested changes Nov 3, 2025
View reviewed changes
Copy link

@Di7design Di7design left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context in chat box looks good. Here is design input for additional context in chat history: Figma
Screenshot for preview
Screenshot 2025-11-03 at 3 06 05 PM

@AdityaHegde AdityaHegde marked this pull request as ready for review November 4, 2025 13:27
@AdityaHegde AdityaHegde requested a review from Di7design November 4, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Di7design Di7design Di7design approved these changes

@ericpgreen2 ericpgreen2 Awaiting requested review from ericpgreen2

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AdityaHegde @Di7design