-
Notifications
You must be signed in to change notification settings - Fork 151
docs: Add model validation documentation (for PR #7344) #8220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Create comprehensive model validation documentation page - Document both 'assert' and 'sql' test syntaxes - Include examples for common validation patterns (null checks, ranges, duplicates, etc.) - Add complete example with various validation types - Document test execution behavior and best practices - Include guidance on test naming, organization, and performance - Add sections on working with incremental and partitioned models - Update models index to reference new validation page Related to PR #7344 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General thoughts?
|
|
||
| ## Viewing Test Results | ||
|
|
||
| Test results are stored in the model state and visible in: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grahamplata to my knowledge, we dont surface this in the UI today right? How does a user see when a model validation fails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't anything available in cloud at the moment
| - Number of rows that failed the test | ||
| - Sample of the failing rows (if applicable) | ||
|
|
||
| ## Best Practices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about this section?
| assert: order_date >= '2020-01-01' | ||
| ``` | ||
|
|
||
| ### Choosing Between Assert and SQL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true?
|
@grahamplata can you look at the remaining two questions? |
Summary
This PR adds comprehensive documentation for model validation, a feature added in PR #7344.
What's Included
New Documentation Page (
model-validation.md)assertandsqltest typesUpdated Models Index - Added reference to validation page in the Fundamentals section
Documentation Highlights
The documentation covers:
assert(condition-based) andsql(query-based) test syntaxesRelated
🤖 Generated with Claude Code