Show default users in create group dialog #8244
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lovincyrus, any reason why we can have infinite scroll here? I think just showing top 5 users is going to make users question why other users are not in this list |
|
If it's because of performance, then perhaps we'll need to label the dropdown with "suggested users" but i would prefer lazy loading and infinite scroll for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows the first five available users, allowing users to select from them when creating a new group. Closes https://linear.app/rilldata/issue/APP-520/user-groups-user-list-isnt-showing-total-list-of-users-in-user
Checklist: