Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@briangregoryholmes
Copy link
Contributor

@briangregoryholmes briangregoryholmes commented Nov 6, 2025

This PR fixes the following issues:

  • Removes the reliance on a resolved dashboardState object for rendering bookmarks and instead processes the saved bookmark URL directly in the dialog component
  • Because of the above, this PR fixes an issue where the bookmark properties would be overwritten with the current dashboard state when editing
  • On Canvas, the grain parameter is not supported: this PR removes instances where it was being set and makes it a little more explicit
  • Prevents the CanvasBookmarks from initializing a canvas store before the dashboard is loaded by removing the need to call getCanvasStore

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@briangregoryholmes briangregoryholmes self-assigned this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants