Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Proper multiple-tab code blocks #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 1, 2023
Merged

Proper multiple-tab code blocks #26

merged 3 commits into from
Mar 1, 2023

Conversation

fundthmcalculus
Copy link
Contributor

@fundthmcalculus fundthmcalculus commented Jan 11, 2022 •
edited
Loading

  • Updates the TODO file list.
  • on pymdownx.tabbed, we need the leading spaces on the tab content.
  • Support for pymdownx v9.0

@fundthmcalculus
Copy link
Contributor Author

@rnorth any plans to merge/update/release this package?

@rnorth
Copy link
Owner

rnorth commented Feb 4, 2022

@fundthmcalculus thank you for the PR - sorry for not looking at it sooner. I'll have a look this evening, and hopefully merge/release shortly.

@rnorth
Copy link
Owner

rnorth commented Feb 5, 2022

It looks like we have some test failures but otherwise this looks good to me. Please could you check?

@rnorth
Copy link
Owner

rnorth commented Feb 5, 2022

Actually it looks like one of the failures would be due to a change in pygments. #27 will fix, but you'll probably want to rebase.

@fundthmcalculus
Copy link
Contributor Author

Updated.

@geel9 geel9 mentioned this pull request May 3, 2022
Closed
@felker
Copy link

felker commented Feb 23, 2023

Is there a reason this wasn't merged last year? I can confirm that these changes are necessary for pymdown-extensions 9.x to support multiple adjacent tabs in pymdownx.tabbed

@felker felker mentioned this pull request Feb 23, 2023
Merged
@rnorth rnorth merged commit 74d9f85 into rnorth:master Mar 1, 2023
@rnorth
Copy link
Owner

rnorth commented Mar 1, 2023

Is there a reason this wasn't merged last year? I can confirm that these changes are necessary for pymdown-extensions 9.x to support multiple adjacent tabs in pymdownx.tabbed

No reason other than personal reasons, I'm afraid! I have merged and will release.

felker added a commit to argonne-lcf/user-guides that referenced this pull request Mar 7, 2023
@felker
Stop using our fork of mkdocs-codeinclude-plugin
e3dbe0d 
Fix for pymdownx 9.x support merged upstream

rnorth/mkdocs-codeinclude-plugin#26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fundthmcalculus @rnorth @felker