Thanks to visit codestin.com
Credit goes to github.com

Skip to content
/ http Public

Remove PHP versions from GitHub Actions, fix the documentation link #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
msmakouz merged 1 commit into from
Feb 5, 2024
Merged

Remove PHP versions from GitHub Actions, fix the documentation link #22

msmakouz merged 1 commit into from
Feb 5, 2024

Conversation

@msmakouz
Copy link
Member

@msmakouz msmakouz commented Feb 5, 2024 •
edited
Loading

Q A
Bugfix? ❌
Breaks BC? ❌
New feature? ❌
  1. Fixed the link to the documentation.
  2. PHP versions have been removed from GitHub Actions (versions 8.1-8.3 specified here: https://github.com/spiral/gh-actions/blob/master/.github/workflows/phpunit.yml#L32, https://github.com/spiral/gh-actions/blob/master/.github/workflows/psalm.yml#L12 will be used).

@msmakouz msmakouz added the documentation Improvements or additions to documentation label Feb 5, 2024
@msmakouz msmakouz self-assigned this Feb 5, 2024
@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2024 •
edited
Loading

Walkthrough

The recent changes involve updating the workflow configurations for both PHPUnit and Psalm by removing the master branch restriction and adjusting PHP version settings. Additionally, there's an update to the README.md, specifically the modification of a hyperlink to Roadrunner's documentation. These updates collectively enhance the project's compatibility and accessibility.

Changes

File Path Change Summary
.github/workflows/ - Removed master branch restriction for push events
- Updated PHP versions in phpunit.yml and psalm.yml, removed PHP 8.1 from Psalm
README.md - Updated Roadrunner documentation URL

🐇✨
Changes afoot in the code, so spry,
Branches and versions, oh how they fly.
A hyperlink shifts, with a small sigh,
Progress hops forward, under the sky. 🌈

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot]
coderabbitai bot reviewed Feb 5, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ddd6432 and e359b78.
Files ignored due to path filters (1)
  • composer.json is excluded by: !**/*.json
Files selected for processing (3)
  • .github/workflows/phpunit.yml (2 hunks)
  • .github/workflows/psalm.yml (2 hunks)
  • README.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • README.md
Additional comments: 1
.github/workflows/psalm.yml (1)
  • 4-6: The branch filter has been updated to trigger on pushes to any branch. Ensure this aligns with the project's workflow and security policies.

.github/workflows/psalm.yml
Comment on lines 12 to 14
with:
os: >-
['ubuntu-latest']
Copy link

@coderabbitai coderabbitai bot Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [10-14]

Using a specific commit or tag instead of master for the uses field could improve stability and predictability of the workflow.

@msmakouz msmakouz merged commit c6fb299 into 3.x Feb 5, 2024
@msmakouz msmakouz deleted the php83 branch February 5, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@rustatian rustatian rustatian approved these changes

@roxblnfk roxblnfk Awaiting requested review from roxblnfk

Assignees

@msmakouz msmakouz

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msmakouz @rustatian